You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The String.format() call has a format specifier in the message but getPort() is passed as an argument that isn't used since the port is already formatted inline with String.format("--port=%d", port)
thrownewNumberFormatException(
String.format(
"Couldn't format the port numbers because the System Language is arabic: \""
+ String.format("--port=%d", port)
+ "\", please make sure to add the required arguments \"-Duser.language=en"
+ " -Duser.region=US\" to your JVM, for more info please visit :\n"
+ " https://www.selenium.dev/documentation/webdriver/browsers/",
getPort()));
The String.format() is used incorrectly. The first argument contains a placeholder (%d) but it's concatenated instead of being part of the format string. This will cause the getPort() parameter to be ignored.
String.format(
- "Couldn't format the port numbers because the System Language is arabic: \""- + String.format("--port=%d", port)- + "\", please make sure to add the required arguments \"-Duser.language=en"- + " -Duser.region=US\" to your JVM, for more info please visit :\n"- + " https://www.selenium.dev/documentation/webdriver/browsers/",- getPort());+ "Couldn't format the port numbers because the System Language is arabic: \"--port=%d\", please make sure to add the required arguments \"-Duser.language=en -Duser.region=US\" to your JVM, for more info please visit :\n https://www.selenium.dev/documentation/webdriver/browsers/",+ port);
Apply this suggestion
Suggestion importance[1-10]: 9
Why: The suggestion correctly identifies a critical bug where nested String.format() usage would cause the port number to be ignored in the final formatted string, potentially leading to incorrect error messages. The proposed fix properly integrates the port parameter into a single format string.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
PR #14946 probably after running format.sh. The message with the next lines added is not consistent anymore, which causes the unit test to fail.
Motivation and Context
Types of changes
Checklist
PR Type
Bug fix
Description
Fixed the
NumberFormatExceptionmessage for Arabic locale.Improved formatting of the exception message for clarity.
Ensured proper handling of port formatting in error messages.
Changes walkthrough 📝
DriverService.java
Refined `NumberFormatException` message for Arabic localejava/src/org/openqa/selenium/remote/service/DriverService.java
NumberFormatExceptionmessage for Arabic locale.